Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert AbstractArray{ComplexF64} to CuArray{ComplexF32} by default #489

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Convert AbstractArray{ComplexF64} to CuArray{ComplexF32} by default #489

merged 1 commit into from
Oct 15, 2020

Conversation

pabloferz
Copy link
Contributor

Fixes #91

maleadt
maleadt reviewed Oct 14, 2020
View reviewed changes
src/array.jl Outdated Show resolved Hide resolved
@maleadt maleadt added the cuda array Stuff about CuArray. label Oct 14, 2020
@maleadt
Copy link
Member

maleadt commented Oct 14, 2020

bors r+

bors bot added a commit that referenced this pull request Oct 14, 2020
@bors @pabloferz
Merge #489
be0d0a8 
489: Convert AbstractArray{ComplexF64} to CuArray{ComplexF32} by default r=maleadt a=pabloferz

Fixes #91

Co-authored-by: Pablo Zubieta <8410335+pabloferz@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Oct 14, 2020

Timed out.

@maleadt
Copy link
Member

maleadt commented Oct 15, 2020

Huh. Let's try again.
bors try

bors bot added a commit that referenced this pull request Oct 15, 2020
@bors
Try #489:
64d0790
@bors
Copy link
Contributor

bors bot commented Oct 15, 2020

try

Build succeeded:

@maleadt maleadt merged commit ede842a into JuliaGPU:master Oct 15, 2020
@pabloferz pabloferz deleted the pz/cucomplex branch October 15, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maleadt maleadt maleadt left review comments

Assignees
No one assigned
Labels
cuda array Stuff about CuArray.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cu() behavior for complex floating point numbers
2 participants
@pabloferz @maleadt