Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KernelAbstractions copyto! typo #336

Closed
101001000 opened this issue Apr 22, 2024 · 0 comments · Fixed by #337
Closed

KernelAbstractions copyto! typo #336

101001000 opened this issue Apr 22, 2024 · 0 comments · Fixed by #337

Comments

@101001000
Copy link
Contributor

in MetalKernels.jl:

36  function KA.copyto!(::MetalBackend, A::MtlArray{T}, B::MtlArray{T}) where T
37      if device(dest) == device(src)
38          GC.@preserve A B copyto!(A, B)
39          return A
40      else
41          error("Copy between different devices not implemented")
42      end
43  end

Calling KA.copyto! with a metal backend will throw: ERROR: LoadError: UndefVarError: dest not defined. Maybe dest and src should be A and B respectively?

101001000 added a commit to 101001000/Metal.jl that referenced this issue Apr 22, 2024
101001000 added a commit to 101001000/Metal.jl that referenced this issue Apr 23, 2024
* Typo fix (JuliaGPU#336)
* Rename variables
101001000 added a commit to 101001000/Metal.jl that referenced this issue Apr 23, 2024
    * Typo fix (JuliaGPU#336)
    * Rename variables
@christiangnrd christiangnrd linked a pull request Apr 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant