Parameterize MtlArray storage mode #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christiangnrd
changed the title
MtlArray storage mode
christiangnrd
force-pushed
the
param_mtlarray
branch
from
d683bd7
to
e340d65
Compare
maleadt
reviewed
May 31, 2023
maleadt
reviewed
May 31, 2023
|
Looks good, thanks!
Which ObjC type did you want to parameterize? |
maleadt
added
enhancement
|
I have addressed your review comments. I'll be adding documentation over the weekend.
I was thinking MTLbuffer. Would there be any benefits to doing so? |
christiangnrd
force-pushed
the
param_mtlarray
branch
from
89b1986
to
7efbb6c
Compare
I don't think so, at least not currently. |
christiangnrd
force-pushed
the
param_mtlarray
branch
from
7efbb6c
to
5e4aff5
Compare
|
I added documentation similar to what CUDA.jl has except that I mention the |
maleadt
reviewed
Jun 5, 2023
Fix fill method Fix typo
|
I forgot to mark it ready for review. Should be good to merge if you deem it so! |
This was referenced Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My initial attempt at #190.
Only touches MtlArray because I could not figure out how to parameterize Obj-C objects. If it's possible, let me know and I'll parameterize MTLBuffer.
Will add docs once the code is reviewed.
To change:
MtlArrayconstructors in array.jlzeros,ones,fillin array.jl to use new interfacerand,randnin random.jl to use new interface