Support loading/saving simdgroup matrix from threadgroup memory #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
tryBuild succeeded: |
maleadt
reviewed
Jan 17, 2023
src/device/intrinsics/memory.jl
Outdated
| @@ -78,6 +78,15 @@ Base.@propagate_inbounds Base.getindex(A::MtlLargerDeviceArray{T}, i1::Integer) | |||
| Base.@propagate_inbounds Base.setindex!(A::MtlLargerDeviceArray{T}, x, i1::Integer) where {T} = | |||
| arrayset(A, convert(T,x)::T, i1) | |||
|
|
|||
| Base.to_index(::MtlLargerDeviceArray{T}, i::Integer) where {T} = i | |||
There was a problem hiding this comment.
Is this needed? I'm assuming you're copying the CUDA.jl perf optimization for Int32 indices here. That doesn't really belong in this PR, but other than that it should definitely have some comments.
There was a problem hiding this comment.
You're right it's not needed, I've removed it.
I copied it over from src/device/array.jl when I was trying to get tg_a[x,y] to work for MtlLargerDeviceArray (which is needed by the test).
|
bors try |
tryBuild succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.