Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on ZygoteRules instead of Zygote #21

Merged
merged 3 commits into from
Jan 15, 2020

Conversation

devmotion
Copy link
Member

IMO KernelFunctions should not depend on Zygote and all its dependencies but rather use ZygoteRules as dependency.

The latest release of SpecialFunctions broke the tests (Pkg can't resolve a compatible set of packages since SpecialFunctions 0.10 is used but ForwardDiff, an implicit dependency of Zygote, does not support it yet), so I fixed SpecialFunctions compatibility to 0.9 and fixed a deprecation warning.

BTW I found CompatHelper quite helpful for being notified about new releases of dependencies 馃檪

@devmotion
Copy link
Member Author

I added SpecialFunctions 0.8 since SpecialFunctions 0.9 is only compatible with Julia 1.3.

@theogf
Copy link
Member

theogf commented Jan 15, 2020

That looks great thanks for the PR

@theogf theogf merged commit c99a56a into JuliaGaussianProcesses:master Jan 15, 2020
@devmotion devmotion deleted the zygote branch January 15, 2020 12:25
@theogf
Copy link
Member

theogf commented Jan 16, 2020

Thanks for the CompatHelper suggestion, I never used it but it's super useful!

@devmotion
Copy link
Member Author

You're welcome 馃槂 I like it a lot, one just has to be a bit careful that the new version is actually used in the tests (sometimes some other dependencies might block it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants