Depend on ZygoteRules instead of Zygote #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added SpecialFunctions 0.8 since SpecialFunctions 0.9 is only compatible with Julia 1.3. |
|
That looks great thanks for the PR |
|
Thanks for the |
|
You're welcome 馃槂 I like it a lot, one just has to be a bit careful that the new version is actually used in the tests (sometimes some other dependencies might block it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO KernelFunctions should not depend on Zygote and all its dependencies but rather use ZygoteRules as dependency.
The latest release of SpecialFunctions broke the tests (Pkg can't resolve a compatible set of packages since SpecialFunctions 0.10 is used but ForwardDiff, an implicit dependency of Zygote, does not support it yet), so I fixed SpecialFunctions compatibility to 0.9 and fixed a deprecation warning.
BTW I found CompatHelper quite helpful for being notified about new releases of dependencies 馃檪