Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement GeoInterface isempty, x, and y. #191

Merged
merged 6 commits into from
Jan 1, 2024
Merged

Implement GeoInterface isempty, x, and y. #191

merged 6 commits into from
Jan 1, 2024

Conversation

evetion
Copy link
Member

@evetion evetion commented Dec 31, 2023

As triggered by JuliaGeo/GeometryOps.jl#33

@evetion evetion requested a review from rafaqz December 31, 2023 16:10
@rafaqz
Copy link
Member

rafaqz commented Jan 1, 2024

Thanks. I guess we need a method for plotting only missing values in GeoInterfaceMakie.jl?

@evetion
Copy link
Member Author

evetion commented Jan 1, 2024

Thanks. I guess we need a method for plotting only missing values in GeoInterfaceMakie.jl?

Not sure, I didn't follow that discussion. I just saw isempty return false, which was clearly incorrect. 😅

@rafaqz
Copy link
Member

rafaqz commented Jan 1, 2024

I mean the test failures

@evetion evetion changed the title Implement GeoInterface isempty Implement GeoInterface isempty, x, and y. Jan 1, 2024
Copy link
Member

@rafaqz rafaqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rafaqz rafaqz merged commit feb0055 into master Jan 1, 2024
11 checks passed
@rafaqz rafaqz deleted the feat/isempty branch January 1, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants