Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return tuple points from GeoInterface methods #193

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rafaqz
Copy link
Member

@rafaqz rafaqz commented Jan 1, 2024

Closes #190

Copy link
Member

@evetion evetion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a merge from master this should be cleaner. I'm fine with this change, but only if we update our constructors to also take Vector of Tuples, so we can reverse.

nit: Please spellcheck your comments ;)

src/geo_interface.jl Outdated Show resolved Hide resolved
src/geo_interface.jl Outdated Show resolved Hide resolved
src/geo_interface.jl Show resolved Hide resolved
src/geo_interface.jl Outdated Show resolved Hide resolved
@rafaqz
Copy link
Member Author

rafaqz commented Jan 7, 2024

Doing this for MultiPoint and coordSeq methods is a huge task that I cant include in this PR. This package needs a rewrite of the internals with the aim of reducing the constant small allocations with some ArchGDAL like closures for safety instead of clones. But who knows when that can happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap to returning Tuples instead of LibGEOS.Point for anything GeoInterface related
2 participants