Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface polish #30

Merged
merged 4 commits into from
Feb 22, 2016
Merged

Interface polish #30

merged 4 commits into from
Feb 22, 2016

Conversation

tomasaschan
Copy link
Contributor

I came to think of a backwards-compatible way of implementing #29, so I went ahead and did it :)

The extra piece that makes this work is that the type that is now returned by contours is also an iterable, so iterating over it the way one previously iterated over the array we returned "just works". However, I'm inclined to immediately deprecate this API, so that with the next tagged release, we start moving people over to using levels and lines rather than property accessors and direct iteration. @darwindarak, does this sound reasonable?

There are now also some tests in test/interface.jl that verify that both the old and the new invocations work.

@codecov-io
Copy link

Current coverage is 92.59%

Merging #30 into master will decrease coverage by -4.15% as of e3e701a

@@            master     #30   diff @@
======================================
  Files            1       1       
  Stmts          123     135    +12
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            119     125     +6
  Partial          0       0       
- Missed           4      10     +6

Review entire Coverage Diff as of e3e701a

Powered by Codecov. Updated on successful CI builds.

@darwindarak
Copy link
Collaborator

That's a cool solution. Looks good to me!

tomasaschan pushed a commit that referenced this pull request Feb 22, 2016
@tomasaschan tomasaschan merged commit cb141cf into master Feb 22, 2016
@tomasaschan tomasaschan mentioned this pull request Aug 11, 2016
@KristofferC KristofferC deleted the interface-polish branch May 4, 2017 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants