Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came to think of a backwards-compatible way of implementing #29, so I went ahead and did it :)
The extra piece that makes this work is that the type that is now returned by
contours
is also an iterable, so iterating over it the way one previously iterated over the array we returned "just works". However, I'm inclined to immediately deprecate this API, so that with the next tagged release, we start moving people over to usinglevels
andlines
rather than property accessors and direct iteration. @darwindarak, does this sound reasonable?There are now also some tests in
test/interface.jl
that verify that both the old and the new invocations work.