Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix depwarn in test #35

Closed
wants to merge 1 commit into from
Closed

Conversation

ranjanan
Copy link

cs -> levels(cs)

@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage decreased (-2.9%) to 88.406% when pulling b1af2c5 on ranjanan:RA/depwarn into 8b59af7 on tlycken:master.

@codecov-io
Copy link

codecov-io commented Aug 11, 2016

Current coverage is 88.40% (diff: 100%)

Merging #35 into master will decrease coverage by 2.89%

@@             master        #35   diff @@
==========================================
  Files             1          1          
  Lines           138        138          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits            126        122     -4   
- Misses           12         16     +4   
  Partials          0          0          

Powered by Codecov. Last update 8b59af7...b1af2c5

@tomasaschan
Copy link
Contributor

tomasaschan commented Aug 11, 2016

Thanks - this should probably have been part of #30 😄

I suspect that we should probably change the next line from c.lines to lines(c) too, to be consistent.

This test is actually supposed to throw a warning; it's there to ensure that the old API works during its deprecation period. I am actually working on removing it altogether - but this PR alerted me to the fact that that change wasn't pushed yet; see de13385.

Thanks anyway!

@ranjanan
Copy link
Author

ranjanan commented Aug 11, 2016

Ah I see, I didn't know it was meant to throw a depwarn. Thanks!

Would you mind adding a comment above that particular test please?

@tomasaschan
Copy link
Contributor

Well, no - because that test is removed on the latest master :P

If you do Pkg.checkout("Contour") to get it, you won't see that warning anymore.

@ranjanan ranjanan deleted the RA/depwarn branch August 11, 2016 09:08
@ranjanan
Copy link
Author

Cool, you're right. 😄 Would you mind tagging a new release then? Or do you want to wait on that?

@tomasaschan
Copy link
Contributor

I'm working on it: JuliaLang/METADATA.jl#5901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants