Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update structarrays compat #146

Merged
merged 3 commits into from
Jun 28, 2021
Merged

Conversation

piever
Copy link
Contributor

@piever piever commented Jun 28, 2021

In StructArrays 0.6, StaticArrays are treated the same way as the underlying Tuple in terms of data storage, so one should pass the tuple of columns directly to the constructor, without having to nest StructArrays.

I'm dropping compatibility with the older version, because it seems tricky to support both.

@piever
Copy link
Contributor Author

piever commented Jun 28, 2021

Tests pass locally, but I'm not sure why the documentation build does not find version StructArrays 0.6

@SimonDanisch
Copy link
Member

Hmmm weird indeed.. Can you try to add an Pkg.up() to the docs ci stage?

@SimonDanisch
Copy link
Member

image

Those other CI stages should run almost exactly the same !? :D

@piever
Copy link
Contributor Author

piever commented Jun 28, 2021

Yeah, not too sure how to debug this... Maybe it's just a matter of waiting a bit and trying again :)

I thought maybe it doesn't find the version because StructArrays 0.6 requires julia 1.3 minimum, but the docs seem to run on 1.6, so that shouldn't be it

@knuesel
Copy link
Contributor

knuesel commented Jun 28, 2021

This is an issue with the PkgServer protocol serving an outdated registry. At first I couldn't reproduce this locally because I had the old Git-clone version of the registry in ~/.julia/registries/General. After removing it and installing StructArrays I got version 0.5.1.

There's a discussion at JuliaRegistries/General#16777 and workarounds have been implemented e.g. at julia-actions/julia-runtest#17 and JuliaCI/PkgTemplates.jl#296.

For example in our case replacing the Pkg.update() line in ci.yml with ENV["JULIA_PKG_SERVER"] = "" would do the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants