-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support heterogeneous features #74
Conversation
@SimonDanisch the basic reason for going down this path is #49 (comment). This PR is only a draft, but do you in general agree with the proposal of moving from We are going with the name |
Oh, yeah...that was 100% the reason, that I didn't go with it :D I think having |
I think that would work for us :) |
I think this is ready to be merged? |
@visr, can you give this a review as well? :) |
Yes, I'll have a look in a day or two. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, left a few comments.
Since this will now only be an extension of the existing Meta types, I don't think Feature
is a good name anymore. Meta
is not an option due to Base.Meta
. Alternatives include MetaT
(like Triangle
/ TriangleP
) or GeometryMeta
/ AnyMeta
which goes more with PointMeta
/ PolygonMeta
.
I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I am extremely sorry for the scattered PR's(both here and in AbstractPlotting). But here's a sequence in which you might want to review/merge them:
|
Hey @SimonDanisch if the changes are fine then this can be merged? |
Sorry for being a bit slow! Thanks for you contribution! |
I haven't removed the old meta implementation as planned due to some issues with
MeshMeta
. But for the new implemetation, tests are almost written.We just need to fix the Mesh issue, add some other helpful constructors.