Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle requests for integer points #42

Closed
sjkelly opened this issue Aug 11, 2019 · 1 comment
Closed

Gracefully handle requests for integer points #42

sjkelly opened this issue Aug 11, 2019 · 1 comment

Comments

@sjkelly
Copy link
Member

sjkelly commented Aug 11, 2019

Caused by #35. In this case I was loading an NRRD file with Int16 data, which is not handled by the current system well.

ERROR: LoadError: InexactError: Int16(0.019569471624266144)
...
 [7] marching_cubes(::GeometryTypes.SignedDistanceField{3,Int64,Int16}, 
::Type{GeometryTypes.Point{3,Int16}}, ::Type{GeometryTypes.Face{3,Int64}}, ::Float64, 
::Type{GeometryTypes.HomogenousMesh}, ::Float64, ::Bool) at /home/steve/.julia/dev/Meshing/src/marching_cubes.jl:33

It might be good to make this a warning with deference to Float64.
@sjkelly
Copy link
Member Author

sjkelly commented Sep 7, 2019

wheres my MWE? 🤦‍♂️

@sjkelly sjkelly mentioned this issue Sep 13, 2019
Closed
sjkelly added a commit that referenced this issue Jan 10, 2020
@sjkelly
test for #42 and default to Float64
078cc0c
@sjkelly sjkelly closed this as completed Jan 10, 2020
@jlchan jlchan mentioned this issue Sep 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sjkelly