[WIP] Generalize internal working types #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeits
reviewed
Jul 24, 2019
rdeits
reviewed
Jul 24, 2019
rdeits
reviewed
Jul 24, 2019
sjkelly
force-pushed
the
sjk/workingprecision
branch
from
42f40d1
to
a019704
Compare
- improve performance for vertex array construction - remove isosurface function - relax types on indices for interation
|
This covers all the algorithms now. My plan is to simplify the internals with a general |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the implementation of #34, currently only on Marching Cubes. I am also working to modernize and optimize the MarchingTetrahedra implementation. The current changes are more than 2x faster and I should be able to implement the direct function sampling API for this method as well.