Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more elementary functions #266

Merged
merged 12 commits into from
Sep 21, 2023

Conversation

hyrodium
Copy link
Collaborator

This PR fixes #234 and #164.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #266 (149cc7a) into master (4240829) will increase coverage by 0.48%.
The diff coverage is 98.38%.

@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
+ Coverage   89.93%   90.42%   +0.48%     
==========================================
  Files          17       17              
  Lines        1619     1660      +41     
==========================================
+ Hits         1456     1501      +45     
+ Misses        163      159       -4     
Files Changed Coverage Δ
src/Rotations.jl 100.00% <ø> (ø)
src/angleaxis_types.jl 97.93% <ø> (+3.87%) ⬆️
src/core_types.jl 95.65% <ø> (-0.07%) ⬇️
src/elementary_functions.jl 98.38% <98.38%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hyrodium
Copy link
Collaborator Author

Oh, we are missing cbrt(::Quaternion) in JuliaGeometry/Quaternions.jl#56 because cbrt(::Complex) is not implemented yet (JuliaLang/julia#36534).

@hyrodium hyrodium merged commit 75c98e3 into JuliaGeometry:master Sep 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for sqrt etc.
1 participant