upgrade mean of rotations to new LinearAlgebra syntax #90
Conversation
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
===========================================
- Coverage 86.99% 71.95% -15.05%
===========================================
Files 9 8 -1
Lines 746 731 -15
===========================================
- Hits 649 526 -123
- Misses 97 205 +108
Continue to review full report at Codecov.
|
src/euler_types.jl
Outdated
| @@ -14,7 +14,7 @@ for axis in [:X, :Y, :Z] | |||
| @eval begin | |||
| struct $RotType{T} <: Rotation{3,T} | |||
| theta::T | |||
| $RotType{T}(theta) where {T} = new{T}(theta) | |||
| $RotType{T}(theta::Real) where {T} = new{T}(theta) | |||
There was a problem hiding this comment.
This change seems unrelated and would break e.g. interop with SymPy.Sym. Please revert.
There was a problem hiding this comment.
oops! haha I left that in by accident. There are some problems with mean() in its current form that I was trying to address. Namely that you cannot take the mean of two or three axis rotations. I'll file an issue for that!
There was a problem hiding this comment.
and I'll definitely add a test. I'm a little slammed right now but in a day or two!
|
Is this one still relevant? |
|
It seems adding tests is not finished, and the return value type of |
mean was complaining about no eigfact function existing. This PR updates to current LinearAlgebra syntax which is eigvecs.