Use 7z.exe from Julia binary download #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: src/AtomShell/install.jl
Remove superfluous 'end' modified: src/AtomShell/install.jl
NHDaly
reviewed
Dec 28, 2018
| download("https://github.com/electron/electron/releases/download/v$version/$file") | ||
| run(`7z x $file -oatom`) | ||
| rm(file) | ||
| arch = Int == Int64 ? "x64" : "ia32" |
There was a problem hiding this comment.
Is there any reason you re-indented this section to 3 spaces instead of 2? Can we put it back to make comparing the diff easier?
That said, i'm not sure why the whole file has 2-space indent instead of 4... I've opened #182 to change that, and i can just merge it after your PR is merged! :)
There was a problem hiding this comment.
No reason! The 2-space indentation was not recognized by my editor, which tries too be a bit smarter than it is.
|
What is the status on this pull request? It would be fantastic if this issue were fixed. |
|
Blink is very widely used among new users, so I think it's one of those packages that might put extra effort like this into "beginner"-friendliness. |
tkoolen
added a commit
to tkoolen/Blink.jl
that referenced
this pull request
Dec 28, 2019
Really, we shouldn't be using 7z.exe at all since it's an internal Julia utility (see e.g. JuliaLang/julia#33687 and JuliaLang/julia#33862 (comment)). In Julia 1.3+, we should probably switch to the Artifacts system at some point, as was also done in davidanthoff/Electron.jl#49 for Electron.jl. But right now, we need a fix for Julia 1.0.5 as well. This rather complex logic was introduced in JuliaGizmos#177. If 7z.exe is not in `joinpath(Sys.BINDIR, Base.LIBEXECDIR` (or its equivalent on versions prior to 1.3). Note that e.g. BinDeps, which is widely used, doesn't even go to the trouble of
tkoolen
added a commit
to tkoolen/Blink.jl
that referenced
this pull request
Dec 28, 2019
JuliaGizmos#177 (comment) This commit is really just to simplify behavior and avoid another wild goose chase in the future. It does not address recent failures on 1.0.5, which are just because the location of the 7z.exe that's shipped with Julia binary distributions on Windows has also changed from 1.0.4 to 1.0.5. Really, we shouldn't be using 7z.exe at all since it's an internal Julia utility (see e.g. JuliaLang/julia#33687 and JuliaLang/julia#33862 (comment)). This rather complex logic was introduced in JuliaGizmos#177 for the case that 7z.exe is not in `joinpath(Sys.BINDIR, Base.LIBEXECDIR` (or its equivalent on versions prior to 1.3). Note that e.g. BinDeps, which is widely used, doesn't even go to the trouble of doing this (https://github.com/JuliaPackaging/BinDeps.jl/blob/3a871c35ef1b0f45760f48088cabd7915838b0e3/src/BinDeps.jl#L116-L120). 7z.exe should only be absent on Windows in case of a native build; it's copied over into the build tree in the `win-extras` `make` target, which is not a dependency of the default `make` target (see https://github.com/JuliaLang/julia/blob/d562715a8f78627627fd0ccf3197de670efbf810/doc/build/distributing.md#windows). The previous logic attempted to find 7z.exe in likely install locations of binary downloads of Julia. I'm personally not convinced by the arguments given here: JuliaGizmos#177 (comment). In Julia 1.3+, we should probably switch to the Artifacts system at some point, as was also done in davidanthoff/Electron.jl#49 for Electron.jl. But right now, we need a fix for Julia 1.0.5 as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. issue #148
modified: src/AtomShell/install.jl
Use (julia)/bin/7z.exe for unpacking. This is not available in home-built Julia. If so, it looks for the latest binary download folder (assuming the installation was not made for all users).
Using home-built-Julia is a prerequisite to using > 4 cores, or due to a known bug, things like