Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat between released version of WebIO (0.8.13) and JSExpr not properly registered? #373

Closed
tkoolen opened this issue Dec 25, 2019 · 2 comments

Comments

@tkoolen
Copy link
Contributor

tkoolen commented Dec 25, 2019

In an empty project on Julia 1.3, I add WebIO and then add JSExpr. status -m shows that the resolver has given me WebIO v0.8.13 and JSExpr v1.0.1. However, WebIO.jl's Project.toml for version 0.8.13 contains

JSExpr = "0.5"

which I understand should be interpreted as [0.5.0, 0.6.0). Could it be that the 0.5 bound somehow didn't make it into the PR to JuliaRegistries/General? I see that it was merged manually, so it appears to me that there's room for error there.

@twavv
Copy link
Member

twavv commented Dec 25, 2019

Thank you for flagging. The actual issue is a bit more complex that I realized.

JSExpr v0.5 depends on WebIO, but in v1.0, we dropped the dependency (and were planning on reversing it for WebIO v1.0). I forgot that WebIO doesn't actually depend on JSExpr though when I added the compat entry.

I'm not sure what the solution to this is. For now, pinning JSExpr to v0.5 works. Sorry for the issues!

Follow along here. JuliaRegistries/General#7145

@twavv
Copy link
Member

twavv commented Dec 26, 2019

Should be "fixed" by JuliaRegistries/General#7165.

@twavv twavv closed this as completed Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants