Get WebIO working on Binder #75
Conversation
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=========================================
- Coverage 54.87% 53.9% -0.97%
=========================================
Files 13 14 +1
Lines 390 397 +7
=========================================
Hits 214 214
- Misses 176 183 +7
Continue to review full report at Codecov.
|
djsegal
changed the title
src/providers/ijulia_setup.jl
Outdated
| .match(/(.*)\\/notebooks\\/(.*)\\.ipynb/); | ||
|
|
||
| if ( curMatch ) { | ||
| \$('head').append('<base href="' + curMatch[1] + '/">'); |
There was a problem hiding this comment.
I don't know if it is as correct as much as it works.
The original idea at the time of writing it was that I was trying to parse out the hostname too.
It does work, though.
Alternatively, we just change:
.match(/(.*)\\/notebooks\\/(.*)\\.ipynb/);
if ( curMatch ) {
\$('head').append('<base href="' + curMatch[1] + '/">');to
.match(/.*\\/notebooks\\/(.*)\\.ipynb/);
if ( curMatch ) {
\$('head').append('<base href="' + curMatch[0] + '/">');There was a problem hiding this comment.
It's confusing to me why you want to extract the name of the notebook.
I thought you wanted to set the base url to everything leading up to the /notebooks/. I'm probably misunderstanding something.
There was a problem hiding this comment.
what i said was completely wrong.
curMatch[0]= the full url (not a partial of the url)
There was a problem hiding this comment.
Sorry. That warning about not accepting PR was pre some other changes.
API for match is:
Quick example for the JS console:
> tmpMatch = window.location.href.match(/(.*)\/JuliaGizmos/)["https://github.com/JuliaGizmos", "https://github.com", index: 0, input: "https://github.com/JuliaGizmos/WebIO.jl/pull/75", groups: undefined]
and then
> tmpMatch[0]
"https://github.com/JuliaGizmos"
> tmpMatch[1]
"https://github.com"
> tmpMatch[2]
undefinedThere was a problem hiding this comment.
Ah, nice! Looks good then. Sorry for not being schooled about how match works. If you revert the scrub output divs commit, I'll hit merge. Appreciate this useful feature!
|
@shashi this is all done at this point. hope i cleared up that one issue. let me know if you have any more thoughts. cheers! |
src/providers/ijulia_setup.jl
Outdated
| display(HTML("<script class='js-remove-script' src='pkg/WebIO/webio/dist/bundle.js'></script>")) | ||
| display(HTML("<script class='js-remove-script' src='pkg/WebIO/providers/ijulia_setup.js'></script>")) | ||
|
|
||
| display(HTML("<script class='js-remove-script'>\$('.js-remove-script').closest('.output_area').remove();</script>")) |
There was a problem hiding this comment.
This will cause reloading the page to lose the JS....
There was a problem hiding this comment.
Very interesting... I'll just do a padding = 0 trick then!
There was a problem hiding this comment.
Sorry for trying to slip that in
attempts to resolve: