-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tuples instead of StaticArrays #42
Comments
Sounds good to me - it's a long time since I made this package (Julia v0.4) ... :) Make sure you don't break the entire plotting ecosystem... :) |
Eeeek that was my worry... We would have to test all the dependent packages before merging. |
Maybe this change merits a major, breaking release? That way you wouldn't (technically) break any package that depends on ColorSchemes. I can't speak for everybody but I'd welcome the improved load times. |
Why would this be a breaking change? Are people doing math with the color vector? It's just a list of colors. |
This mostly works and package load time is less than half of what it is with StaticArrays, but documentation breaks I think using Tuples loses a bunch of |
I don't think there are any tests for |
I really like seeing the colorscheme in atom - I guess it would mean adding a method here in Colors.jl? The |
Maybe |
As @KristofferC just mentioned in #33 we could use a tuple instead of a Vector for colors chemes, and remove the StaticArrays.jl dependency.
Is there any reason colors need to be in a
Vector
? I (probably wrongly) assumed there was when I added the dependency to StaticArrays.jl to speed up color-scheme indexing. Tuples are cleaner and would improve package load time a lot, and the load time of other packages like Gaston.jl.I'll write the PR if there is no problem with making the change.
The text was updated successfully, but these errors were encountered: