Performance improvements #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks awesome! Travis complains about this: Is this caused by something here? Oh, this was probably caused by a recent PR in ColorTypes JuliaGraphics/ColorTypes.jl#178 |
|
What's the advantage of StaticArrays over using a tuple? Do you need to do math on the vector? |
|
I used static arrays so as to not change the interface too much in the PR, not knowing why they were vectors in the first place or what the other use cases are. I'm fine with them being tuples, StaticArrays.jl is a bit too heavy a dependency really. |
|
Is this for Gaston.jl load times? lets swap to tuples. |
Yes, at least that's why I looked at the load time for this package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes type stability issues, and uses StaticArrays for colorschemes. I'm getting over an order of magnitude performance improvement displaying live simulations with colorschemes.