Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forced conversion of weight type in weighted_color_mean #441

Merged
merged 1 commit into from
May 4, 2021

Conversation

kimikage
Copy link
Collaborator

This slightly changes the results for colors with low-precision eltypes(e.g. N0f8).

This change will be applied in v0.13.
Fixes #430

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #441 (0e9ddb7) into master (65c4e5a) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #441      +/-   ##
==========================================
- Coverage   91.21%   91.20%   -0.01%     
==========================================
  Files           9        9              
  Lines         956      955       -1     
==========================================
- Hits          872      871       -1     
  Misses         84       84              
Impacted Files Coverage Δ
src/utilities.jl 97.26% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65c4e5a...0e9ddb7. Read the comment docs.

This slightly changes the results for colors with low-precision eltypes(e.g. `N0f8`).
@kimikage kimikage marked this pull request as ready for review April 29, 2021 10:32
@kimikage kimikage merged commit 7c08a16 into JuliaGraphics:master May 4, 2021
@kimikage kimikage deleted the issue430 branch May 4, 2021 06:38
kimikage added a commit to kimikage/Colors.jl that referenced this pull request May 11, 2024
…iaGraphics#441)

This slightly changes the results for colors with low-precision eltypes (e.g. `N0f8`).
kimikage added a commit that referenced this pull request May 11, 2024
This slightly changes the results for colors with low-precision eltypes (e.g. `N0f8`).
@kimikage kimikage mentioned this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stopping forced conversion of weight type in weighted_color_mean
1 participant