Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.12.8 #472

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Version 0.12.8 #472

merged 1 commit into from
Apr 27, 2021

Conversation

kimikage
Copy link
Collaborator

This adds the support for ColorTypes v0.11. The changes in ColorTypes v0.11 are mainly related to ColorVectorSpace, and do not directly affect the Colors.jl API.
This also modifies the CI settings and removes @asserts from the precompilation script.

@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #472 (c37e560) into master (007a8c8) will increase coverage by 0.66%.
The diff coverage is 70.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
+ Coverage   90.54%   91.21%   +0.66%     
==========================================
  Files           9        9              
  Lines         952      956       +4     
==========================================
+ Hits          862      872      +10     
+ Misses         90       84       -6     
Impacted Files Coverage Δ
src/precompile.jl 0.00% <0.00%> (ø)
src/conversions.jl 100.00% <100.00%> (+0.70%) ⬆️
src/colormaps.jl 95.04% <0.00%> (+3.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4886a0...c37e560. Read the comment docs.

This adds the support for ColorTypes v0.11.
This also modifies the CI settings and removes `@assert`s from the precompilation script.
@kimikage kimikage marked this pull request as ready for review April 27, 2021 03:43
@kimikage kimikage closed this Apr 27, 2021
@kimikage kimikage reopened this Apr 27, 2021
@kimikage kimikage merged commit 65c4e5a into JuliaGraphics:master Apr 27, 2021
@kimikage kimikage deleted the version-0.12.8 branch April 27, 2021 03:54
@@ -193,6 +193,7 @@ end

# Issue #257
c = RGB{Float16}(0.9473,0.962,0.9766)
convert(HSI, c)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, there is garbage left. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant