Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation; fix gplothtml; add TagBot #174

Merged
merged 7 commits into from Jul 26, 2022

Conversation

hdavid16
Copy link
Contributor

@hdavid16 hdavid16 commented Jul 21, 2022

-distinguish between args, kwargs
-add missing kwargs
-fix bug in gplothtml
-enable gplothtml to accept same input as gplot
-add TagBot workflow

-distinguish args, kwargs
-add missing kwargs
clarify that Cairo is required to visualize in vscode
Checking for System OS was outdated
@hdavid16 hdavid16 changed the title Improve Readme and gplot docstring Improve documentation and fix bug in gplothtml Jul 21, 2022
-allow gplothtml to accept same arguments as gplot
-allow x/y-locs to be of different type (<: Real)
@hdavid16 hdavid16 changed the title Improve documentation and fix bug in gplothtml Improve documentation; fix gplothtml; add TagBot Jul 26, 2022
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #174 (222fb26) into master (9e0d037) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #174      +/-   ##
==========================================
- Coverage   33.11%   32.92%   -0.20%     
==========================================
  Files           9        9              
  Lines         456      565     +109     
==========================================
+ Hits          151      186      +35     
- Misses        305      379      +74     
Impacted Files Coverage Δ
src/plot.jl 62.63% <0.00%> (-1.00%) ⬇️
src/shape.jl 0.00% <0.00%> (ø)
src/stress.jl 0.00% <0.00%> (ø)
src/pienode.jl 0.00% <0.00%> (ø)
src/deprecations.jl 0.00% <0.00%> (ø)
src/collapse_plot.jl 0.00% <0.00%> (ø)
src/lines.jl 52.22% <0.00%> (+0.19%) ⬆️
src/layout.jl 48.42% <0.00%> (+1.58%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@etiennedeg
Copy link
Member

I think this should not be controversial, so I merge

@etiennedeg etiennedeg merged commit 52f4aae into JuliaGraphs:master Jul 26, 2022
@hdavid16
Copy link
Contributor Author

Thanks @etiennedeg. Next time we get a patch release registered with JuliaRegistrator, we'll hopefully get the repo version updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants