Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ZlibBuilder #40

Merged
merged 1 commit into from
Mar 2, 2019
Merged

bump ZlibBuilder #40

merged 1 commit into from
Mar 2, 2019

Conversation

bicycle1885
Copy link
Member

This may fix #37. @CiaranOMara, can you try this branch?

@codecov-io
Copy link

codecov-io commented Mar 1, 2019

Codecov Report

Merging #40 into master will increase coverage by 6.83%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage      83%   89.83%   +6.83%     
==========================================
  Files           3        4       +1     
  Lines         100      118      +18     
==========================================
+ Hits           83      106      +23     
+ Misses         17       12       -5
Impacted Files Coverage Δ
src/CodecZlib.jl 100% <0%> (ø)
src/libz.jl 86.66% <0%> (+0.95%) ⬆️
src/decompression.jl 91.66% <0%> (+6.66%) ⬆️
src/compression.jl 88.88% <0%> (+8.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b22773f...c550a5f. Read the comment docs.

@CiaranOMara
Copy link

Commit c550a5f on branch bump-zlib looks promising.

uname -a
FreeBSD hal.novalocal 12.0-RELEASE-p2 FreeBSD 12.0-RELEASE-p2 GENERIC  amd64
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.1.0 (2019-01-21)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

(v1.1) pkg> activate .

(tmp) pkg> add CodecZlib#c550a5f
  Updating registry at `~/.julia/registries/General`
  Updating git-repo `https://github.com/JuliaRegistries/General.git`
   Cloning git-repo `https://github.com/bicycle1885/CodecZlib.jl.git`
  Updating git-repo `https://github.com/bicycle1885/CodecZlib.jl.git`
 Resolving package versions...
  Updating `/usr/home/username/tmp/Project.toml`
  [944b1d66] + CodecZlib v0.5.1+ #c550a5f (https://github.com/bicycle1885/CodecZlib.jl.git)
  Updating `/usr/home/username/tmp/Manifest.toml`
  [b99e7846] + BinaryProvider v0.5.3
  [944b1d66] + CodecZlib v0.5.1+ #c550a5f (https://github.com/bicycle1885/CodecZlib.jl.git)
  [3bb67fe8] + TranscodingStreams v0.8.1
  [2a0f44e3] + Base64 
  [ade2ca70] + Dates 
  [8ba89e20] + Distributed 
  [b77e0a4c] + InteractiveUtils 
  [76f85450] + LibGit2 
  [8f399da3] + Libdl 
  [56ddb016] + Logging 
  [d6f4376e] + Markdown 
  [44cfe95a] + Pkg 
  [de0858da] + Printf 
  [3fa0cd96] + REPL 
  [9a3f8284] + Random 
  [ea8e919c] + SHA 
  [9e88b42a] + Serialization 
  [6462fe0b] + Sockets 
  [8dfed614] + Test 
  [cf7118a7] + UUIDs 
  [4ec0a83e] + Unicode 
  Building CodecZlib → `~/.julia/packages/CodecZlib/FnrOK/deps/build.log`

(tmp) pkg> test CodecZlib
   Testing CodecZlib
    Status `/tmp/tmp1IH17J/Manifest.toml`
  [b99e7846] BinaryProvider v0.5.3
  [944b1d66] CodecZlib v0.5.1+ #c550a5f (https://github.com/bicycle1885/CodecZlib.jl.git)
  [3bb67fe8] TranscodingStreams v0.8.1
  [2a0f44e3] Base64  [`@stdlib/Base64`]
  [ade2ca70] Dates  [`@stdlib/Dates`]
  [8ba89e20] Distributed  [`@stdlib/Distributed`]
  [b77e0a4c] InteractiveUtils  [`@stdlib/InteractiveUtils`]
  [76f85450] LibGit2  [`@stdlib/LibGit2`]
  [8f399da3] Libdl  [`@stdlib/Libdl`]
  [56ddb016] Logging  [`@stdlib/Logging`]
  [d6f4376e] Markdown  [`@stdlib/Markdown`]
  [44cfe95a] Pkg  [`@stdlib/Pkg`]
  [de0858da] Printf  [`@stdlib/Printf`]
  [3fa0cd96] REPL  [`@stdlib/REPL`]
  [9a3f8284] Random  [`@stdlib/Random`]
  [ea8e919c] SHA  [`@stdlib/SHA`]
  [9e88b42a] Serialization  [`@stdlib/Serialization`]
  [6462fe0b] Sockets  [`@stdlib/Sockets`]
  [8dfed614] Test  [`@stdlib/Test`]
  [cf7118a7] UUIDs  [`@stdlib/UUIDs`]
  [4ec0a83e] Unicode  [`@stdlib/Unicode`]
Test Summary: | Pass  Total
Gzip Codec    |  538    538
Test Summary: | Pass  Total
Zlib Codec    |  529    529
Test Summary: | Pass  Total
Deflate Codec |  501    501
Test Summary:      | Pass  Total
TranscodingStreams | 1028   1028
   Testing CodecZlib tests passed
/CodecZlib.jl  ⎇ bump-zlib  deps  julia build.jl --verbose
[ Info: Directory /usr/home/username/CodecZlib.jl/deps/usr/lib does not exist!
[ Info: Downloading https://github.com/bicycle1885/ZlibBuilder/releases/download/v1.0.4/Zlib.v1.2.11.x86_64-unknown-freebsd11.1.tar.gz to /usr/home/username/CodecZlib.jl/deps/usr/downloads/Zlib.v1.2.11.x86_64-unknown-freebsd11.1.tar.gz...
[04:09:26] ######################################################################## 100.0%
[ Info: No hash cache found
[ Info: Calculated hash 87522b29c8dfb7681209fea541dcc09bd5863f55df9cb1de1645ec8484aad7b8 for file /usr/home/username/CodecZlib.jl/deps/usr/downloads/Zlib.v1.2.11.x86_64-unknown-freebsd11.1.tar.gz
[ Info: Installing /usr/home/username/CodecZlib.jl/deps/usr/downloads/Zlib.v1.2.11.x86_64-unknown-freebsd11.1.tar.gz into /usr/home/username/CodecZlib.jl/deps/usr
[ Info: Found a valid dl path libz.so while looking for libz
[ Info: /usr/home/username/CodecZlib.jl/deps/usr/lib/libz.so matches our search criteria of libz
[ Info: Found a valid dl path libz.so while looking for libz
[ Info: /usr/home/username/CodecZlib.jl/deps/usr/lib/libz.so matches our search criteria of libz

@bicycle1885
Copy link
Member Author

Thank you. Good to hear that!

@bicycle1885 bicycle1885 merged commit 631bdaa into master Mar 2, 2019
@bicycle1885 bicycle1885 deleted the bump-zlib branch March 2, 2019 05:47
@bicycle1885
Copy link
Member Author

I'm going to release this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build error on FreeBSD for v0.5.1.
3 participants