Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that @check always clear error stack. #186

Closed
wants to merge 1 commit into from

Conversation

lupemba
Copy link

@lupemba lupemba commented Nov 6, 2023

References

This PR is created to solve issue #185. It should also help with issue #180

Description

I have tried to make a slightly more general fix. @check will now handle elements in XML_GLOBAL_ERROR_STACK also when the ccall completes as expected. These elements will be handled as warnings. This also allows us to remove the show_warnings from the html readers and just have it as a general part of @check. Positive side note is that 'EzXML' now can parse XMLs with invalid xmlns.

A test cases have been added to ensure that it solves the original issue.

@sjkelly
Copy link
Member

sjkelly commented Nov 7, 2023

Looks good to me! I think the @check macro is the robust location to do this.

@sjkelly sjkelly self-assigned this Nov 7, 2023
@sjkelly
Copy link
Member

sjkelly commented Nov 9, 2023

Is this still needed after #143?

@sjkelly
Copy link
Member

sjkelly commented Nov 9, 2023

Also needs a rebase now

@lupemba
Copy link
Author

lupemba commented Nov 9, 2023

Is this still needed after #143?

Not really,
The handling of warnings works for issue #185 now. I still think it would be more robust having the show_warnings in the check macro but it is way more difficult now with the new show_warnings options.

@lupemba lupemba closed this Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants