Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the error message test after PR #162 #189

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

lupemba
Copy link

@lupemba lupemba commented Nov 8, 2023

After PR #162 the error message says "throwing" and not "showing".
This fixes the tests.

After PR JuliaIO#162 the error message says "throwing" and not "showing".
@lupemba
Copy link
Author

lupemba commented Nov 8, 2023

@sjkelly This should fix the test pipeline.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ff3a91) 97.71% compared to head (5a80178) 96.60%.
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   97.71%   96.60%   -1.11%     
==========================================
  Files           7        7              
  Lines         963      884      -79     
==========================================
- Hits          941      854      -87     
- Misses         22       30       +8     
Files Coverage Δ
src/error.jl 96.55% <100.00%> (-0.68%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjkelly sjkelly merged commit 245242e into JuliaIO:master Nov 8, 2023
12 of 13 checks passed
@sjkelly
Copy link
Member

sjkelly commented Nov 8, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants