Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Register fst file format #157

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidanthoff
Copy link
Contributor

Don't merge yet, we first need to sort out various things in the upstream packages.

@timholy
Copy link
Member

timholy commented Nov 19, 2017

Are there really no magic bytes? In this case fst seems to mean several things:

I bet you don't mean the first, but even knowing you I can't guess which of the other two you're hoping to support.

@davidanthoff
Copy link
Contributor Author

I’m trying to find out. This will hopefully support the third format.

@davidanthoff
Copy link
Contributor Author

Because we asked them to, they are actually adding a magic byte into the next version :) I'll follow up on this once everything is ready, will probably still be a while.

@timholy
Copy link
Member

timholy commented Dec 18, 2017

Open source at its finest!

@ViralBShah ViralBShah marked this pull request as draft January 9, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants