Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some precompile and nospecialize statements #243

Merged
merged 1 commit into from Dec 12, 2019
Merged

Conversation

timholy
Copy link
Member

@timholy timholy commented Dec 10, 2019

Together with a companion PR in ImageMagick, this shaves about 1s off the first call to testimage("lighthouse"). It would still be nice to do even better (it takes more than 5s altogether), but at least it's progress.

@codecov
Copy link

codecov bot commented Dec 10, 2019

Codecov Report

Merging #243 into master will decrease coverage by 5.39%.
The diff coverage is 23.52%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #243     +/-   ##
=========================================
- Coverage   80.89%   75.49%   -5.4%     
=========================================
  Files           7        8      +1     
  Lines         382      408     +26     
=========================================
- Hits          309      308      -1     
- Misses         73      100     +27
Impacted Files Coverage Δ
src/loadsave.jl 85.91% <ø> (+0.4%) ⬆️
src/precompile.jl 0% <0%> (ø)
src/types.jl 65.78% <80%> (ø) ⬆️
src/query.jl 81.81% <0%> (-3.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4440da4...dfca650. Read the comment docs.

@timholy timholy changed the title Add some precompile statements Add some precompile and nospecialize statements Dec 12, 2019
@timholy timholy merged commit 9d33726 into master Dec 12, 2019
@timholy timholy deleted the teh/precompile branch December 12, 2019 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant