Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around Julia 1.0.x segfault and fix doc warning #249

Merged
merged 2 commits into from
Dec 30, 2019
Merged

Conversation

timholy
Copy link
Member

@timholy timholy commented Dec 30, 2019

Works around JuliaLang/julia#34121
Fixes #246

@timholy timholy merged commit 2f0d3f7 into master Dec 30, 2019
@timholy timholy deleted the teh/julia34121 branch December 30, 2019 11:22
@codecov
Copy link

codecov bot commented Dec 30, 2019

Codecov Report

Merging #249 into master will increase coverage by 0.73%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   75.49%   76.22%   +0.73%     
==========================================
  Files           8        8              
  Lines         408      408              
==========================================
+ Hits          308      311       +3     
+ Misses        100       97       -3
Impacted Files Coverage Δ
src/types.jl 65.78% <100%> (ø) ⬆️
src/query.jl 85.71% <0%> (+3.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d99436...e4a3a27. Read the comment docs.

@timholy timholy mentioned this pull request Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: Replacing docs
1 participant