Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check eof before read bytes #346

Merged
merged 1 commit into from
Jun 21, 2021
Merged

check eof before read bytes #346

merged 1 commit into from
Jun 21, 2021

Conversation

johnnychen94
Copy link
Member

#345 is introduced by #343. It turns out that seek is not defined for GZip stream object GzipDecompressor, so here it uses a per-byte strategy to check the io length.

This is a bug fix so I'll merge quickly and tag a patch version for it.

fixes #345

cc: @jonasjonker @alyst

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #346 (834037a) into master (01b504d) will decrease coverage by 0.20%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   88.29%   88.09%   -0.21%     
==========================================
  Files          10       10              
  Lines         641      655      +14     
==========================================
+ Hits          566      577      +11     
- Misses         75       78       +3     
Impacted Files Coverage Δ
src/registry.jl 89.65% <80.95%> (-1.60%) ⬇️
src/query.jl 96.77% <0.00%> (+0.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01b504d...834037a. Read the comment docs.

@johnnychen94 johnnychen94 merged commit af40e8a into master Jun 21, 2021
@johnnychen94 johnnychen94 deleted the jc/r_checked branch June 21, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RData can't load .rda files with FileIO@1.10.0 but can with FileIO@1.9.0
1 participant