Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround windows failure #349

Merged
merged 1 commit into from Sep 8, 2021
Merged

Workaround windows failure #349

merged 1 commit into from Sep 8, 2021

Conversation

timholy
Copy link
Member

@timholy timholy commented Sep 8, 2021

For reasons not understood, Windows fails to download the test files
under Julia 1.0. It would be great if someone debugged this, but in the
meantime it seems best to work around the failure.

For reasons not understood, Windows fails to download the test files
under Julia 1.0. It would be great if someone debugged this, but in the
meantime it seems best to work around the failure.
@timholy
Copy link
Member Author

timholy commented Sep 8, 2021

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #349 (96fd349) into master (ba94b81) will decrease coverage by 0.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
- Coverage   87.34%   87.07%   -0.27%     
==========================================
  Files          10       10              
  Lines         656      681      +25     
==========================================
+ Hits          573      593      +20     
- Misses         83       88       +5     
Impacted Files Coverage Δ
src/error_handling.jl 77.27% <0.00%> (-2.73%) ⬇️
src/registry_setup.jl 95.76% <0.00%> (-0.64%) ⬇️
src/precompile.jl 0.00% <0.00%> (ø)
src/loadsave.jl 98.79% <0.00%> (+0.01%) ⬆️
src/deprecated.jl 47.91% <0.00%> (+0.09%) ⬆️
src/registry.jl 89.83% <0.00%> (+0.17%) ⬆️
src/query.jl 96.96% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba94b81...96fd349. Read the comment docs.

@timholy
Copy link
Member Author

timholy commented Sep 8, 2021

OSX stuck. Merge anyway.

@timholy timholy merged commit feace42 into master Sep 8, 2021
@timholy timholy deleted the teh/fixtest_windows branch September 8, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant