More concrete Gadget2 format detector

[islent]

Probably fix #350

[codecov]

Codecov Report

Merging #351 (d476385) into master (e04d83d) will increase coverage by 0.89%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   87.44%   88.34%   +0.89%     
==========================================
  Files          10       10              
  Lines         693      695       +2     
==========================================
+ Hits          606      614       +8     
+ Misses         87       81       -6     

Impacted Files	Coverage Δ
src/registry.jl	93.22% <100.00%> (+3.38%)	⬆️
src/query.jl	96.99% <0.00%> (+0.02%)	⬆️
src/registry_setup.jl	95.79% <0.00%> (+0.03%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e04d83d...d476385. Read the comment docs.

[johnnychen94]

@junglegobs can you help verify this?

[timholy]

Thanks @islent !

@junglegobs can you help verify this?

We wouldn't need help if someone would contribute an actual test file for Gadget2 😄.

Let's wait a few more days for confirmation (I'm unfamiliar with this format) and if we don't hear back, let's merge.

[islent]

Hello, I've uploaded the test file, and implemented a simple testset.
785c5e6#diff-4d1be1e202c2e00168e38c662330eb9f41661071b5bc947c6b1f0e83150a2cc3

[islent]

Need help :D. How could tests on nightly build fail? Should we care about that?

[johnnychen94]

I don't know Gadget2 format so I'm not sure if this breaks people's workflow. But I also don't think my unfamiliarity should block this PR.

The test failure on nightly builds might be unrelated upstream issues. I also noticed that Pkg fails https://github.com/JuliaLang/Pkg.jl/runs/4029907658?check_suite_focus=true

[johnnychen94]

Let's test this in the wild.