Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes create_dataset for compound types #1069

Merged
merged 2 commits into from
May 18, 2023
Merged

Fixes create_dataset for compound types #1069

merged 2 commits into from
May 18, 2023

Conversation

tamasgal
Copy link
Contributor

A small fix of create_dataset which choked when passing your own structs.

Closes #1068

@mkitti
Copy link
Member

mkitti commented May 16, 2023

You beat me to it.

@mkitti
Copy link
Member

mkitti commented May 16, 2023

Could you look over #1067 ? I want merge this one and that one together and check the composition.

@tamasgal
Copy link
Contributor Author

Ah, I missed that one 😉 I'll have a look.

@tamasgal
Copy link
Contributor Author

tamasgal commented May 16, 2023 •
edited

I confirm that all tests pass after merging this (#1069) into #1067.

Test Summary: | Pass  Broken  Total   Time
HDF5.jl       | 1119       5   1124  47.4s
     Testing HDF5 tests passed

@tamasgal
Copy link
Contributor Author

Do you need anything else? ;)

@mkitti
Copy link
Member

mkitti commented May 17, 2023

Just need to look into the JLD thing.

@mkitti
Copy link
Member

mkitti commented May 18, 2023

OK the JLD tests finally passed. Let's merge.

@mkitti mkitti merged commit 2ac2598 into JuliaIO:master May 18, 2023
15 checks passed
@tamasgal tamasgal deleted the fix-datatype-for-compound-types branch May 18, 2023 21:01
@tamasgal
Copy link
Contributor Author

What do you think about a patch release, now with the strings and this being fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating compound datasets is not working
2 participants
@tamasgal @mkitti