Fix depwarns on julia 0.7 #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failure on OS X (all versions) is #483, unrelated to this PR. |
musm
reviewed
Jul 25, 2018
| @@ -1,6 +1,9 @@ | |||
| using HDF5 | |||
| using Compat.Test | |||
| using Compat.Distributed | |||
| @static if VERSION ≥ v"0.7.0-DEV.3637" | |||
There was a problem hiding this comment.
Is the @static is necessary here since it's in global scope?
There was a problem hiding this comment.
As far as I understand, @static means "evaluate the conditional at parse time". It shouldn't be related to the scope.
musm
reviewed
Jul 25, 2018
src/HDF5.jl
Outdated
| @@ -1969,7 +1982,7 @@ end | |||
| ### Convenience wrappers ### | |||
| # These supply default values where possible | |||
| # See also the "special handling" section below | |||
| h5a_write(attr_id::Hid, mem_type_id::Hid, buf::String) = h5a_write(attr_id, mem_type_id, Vector{UInt8}(buf)) | |||
| h5a_write(attr_id::Hid, mem_type_id::Hid, buf::String) = h5a_write(attr_id, mem_type_id, Vector{UInt8}(codeunits(buf))) | |||
There was a problem hiding this comment.
isn't it better to use unsafe_wrap here instead to avoid the extra allocation?
also enables CI testing on 0.7
|
thank you very much, will merge after latest tests are complete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, tests pass (locally) without deprecation warnings on both 0.6 and 0.7.
It also fixes a warning about using Mmap, which doesn't appear in HDF5 tests but appears when running JLD tests.
It also enables CI testing on 0.7.