Bundle zlib alongside HDF5 #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes problems in testing HDF5 on systems that have a system-wide
libzthat is too old for other packages that ship Julia'slibzbut HDF5 gets loaded first, and so loads the systemlibz. So while HDF5 itself was compiled against a very oldlibzand is thus very compatible, it can cause problems for other packages.This will be solved in Julia 1.3+ where the dependency of
HDF5uponZlibwill be automatically encoded in the JLL package dependency graph, but this is an important fix for 1.2-.