New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow UnionAll in Unions #206
Conversation
@DilumAluthge , Would you be willing to inspect my changes? |
Honestly, I don't think I'm qualified to review this PR. It's been a while since I looked at this part of the code, and even then I wasn't very familiar with it. I looked over the changes and nothing seemed glaringly incorrect, but take that with a huge grain of salt. |
It looks like this change might be backwards-compatible. That being said, it is a significant change to existing code. Just to be 100% safe, it might be a good idea to make this PR a breaking change, i.e. bump the version number to 0.2.0. |
Thank you for looking at it. I definitely agree that this not a patch release since files written with this code will not be readable with older JLD2 versions. |
Codecov Report
@@ Coverage Diff @@
## master #206 +/- ##
==========================================
+ Coverage 88.86% 89.02% +0.16%
==========================================
Files 19 20 +1
Lines 2182 2206 +24
==========================================
+ Hits 1939 1964 +25
+ Misses 243 242 -1
Continue to review full report at Codecov.
|
This PR modifies the way
Union
s are written to file and thus allows saving unions that containUnionAll
ssuch as
Vector
e.g. any parametric struct without the parameterization.This needs tests!
Important
This is a breaking change.
closes #187
closes #109
closes #65
EDIT
This is now backwards compatible in that old files can still be read!