eval-free reconstructed types #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasIsensee
force-pushed
the
newreconstruction
branch
from
8f948c8
to
4949a87
Compare
added 2 commits
July 23, 2023 20:31
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #476 +/- ##
==========================================
- Coverage 86.06% 77.14% -8.92%
==========================================
Files 31 32 +1
Lines 4169 4700 +531
==========================================
+ Hits 3588 3626 +38
- Misses 581 1074 +493
☔ View full report in Codecov by Sentry. |
added 2 commits
July 23, 2023 21:21
edls-group
reviewed
Jul 25, 2023
| fields::Vector{Any} | ||
| end | ||
|
|
||
| function Base.getproperty(rc::ReconstructedMutable{N,FN,FT}, s::Symbol) where {N,FN,FT} |
There was a problem hiding this comment.
you'll have to overwrite propertynames as well, else it defaults to using the field names (which are not accessible here)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #298
closes #37