-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate use of undocumented Base.utf16_* functions (Fix #110) #111
Conversation
LGTM. |
Test failure:
|
Its perfectly possible those things that were in the <= 0.3.0- block were broken, as that code path hasn't been tested in 1 year+. |
@ScottPJones, note that you should put |
Yes, I know that, just rushing to get this fixed, sorry! |
@IainNZ You were correct, I shouldn't have relied on those old functions (they didn't cast to UInt32 before doing the << 10, and lost the top bits). They looked almost identical to what was in utf16.jl, |
Heh, yeah. I figured your Unicode-foo would know what the right thing to do was, hopefully Travis agrees! |
Now, if somebody can merge this, so I don't annoy people trying to use JSON 😢! |
Waiting for CI to go green |
Smart man! Thinking about it, I wonder if the old code just bit rotted. Did unsigned values used to end up as UInt, like signed values? I tripped over when I started in Julia because of the fact that unsigned values go from UInt8, UInt16, UInt32 instead of UInt) |
Eliminate use of undocumented Base.utf16_* functions (Fix #110)
Not sure |
Tagging now |
Yes, in old versions of Julia, integer arithmetic promoted to |
This package used two undocumented, unexported functions from
base/utf16.jl
.This removes that dependency, which broke things when those functions were renamed.