Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for v0.7 #252

Merged
merged 4 commits into from Jul 2, 2018
Merged

Fixes for v0.7 #252

merged 4 commits into from Jul 2, 2018

Conversation

fredrikekre
Copy link
Contributor

Most notably removes dependency on Nullables and Compat.

@stevengj
Copy link
Member

I would have preferred to keep 0.6 support until a little while after 0.7 is released, and then have a separate PR dropping compat...

@fredrikekre
Copy link
Contributor Author

Fair enough, should we then wait with the Nullable{T} -> Union{T, Nothing} change too?

@KristofferC
Copy link
Member

Last functional commit here was four months ago and it is always possible to backport something and release from another branch if the need arises.

@Keno
Copy link
Member

Keno commented Jul 1, 2018

I agree, this package is fairly stable and if we're doing a somewhat breaking change in this package (Nullable -> Union{T, Nothing}), it would be good to get that in early, so other packages can adjust to these changes. Otherwise we'll have a second wave of instability as we upgrade packages. Releasing a hotfix from a branch should be just fine.

@Keno
Copy link
Member

Keno commented Jul 1, 2018

@stevengj are you ok with that approach? Lots of packages depend on JSON.jl, so it would be good to get a compatible version out soon.

@stevengj
Copy link
Member

stevengj commented Jul 2, 2018

Okay.

Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fredrikekre. I'll kick off another PkgEval run as soon as this is merged/tagged.

@ararslan ararslan merged commit a822864 into JuliaIO:master Jul 2, 2018
@fredrikekre fredrikekre deleted the fe/0.7 branch July 2, 2018 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants