Fix deprecation of int(x) in Julia 0.4 #25
Conversation
| @@ -163,7 +163,7 @@ cb_end_cdata = cfunction(end_cdata, Void, (Ptr{Void},)) | |||
| function cdata (p_xph::Ptr{Void}, s::Ptr{Uint8}, len::Cint) | |||
| xph = unsafe_pointer_to_objref(p_xph)::XPHandle | |||
|
|
|||
| txt = bytestring(s, int(len)) | |||
| txt = bytestring(s, Int(len)) | |||
| push!(xph.pdata.elements, txt) | |||
There was a problem hiding this comment.
Needs to be @compat(Int(len))
There was a problem hiding this comment.
Line 63 of src/streaming.jl also needs this treatment.
|
Thanks, @axsk -- if you make the changes I marked inline, we can get your PR merged. |
|
If you haven't seen it yet, running |
|
When you make the edits, please squash them to one atomic commit (so there's not an intermediate commit that doesn't work on 0.3). Thanks! |
|
Shouldn't Travis be running here? |
|
@tkelman It should be (as of #23). I just flipped off Travis's 'Build only if .travis.yml is present' switch, though that shouldn't make a difference. The other switches are on. @amitmurthy Could you check that this package (GitHub) Settings -> Webhooks & Services has That's supposed to be taken care of when you turned on Travis -- not sure how easiest to fix it if not, but @tkelman may know. |
|
This is what it looks like now. I don't see a green checkmark.
|
|
That looks like it's disabled for some reason, does it let you turn it back on if you click edit? |
|
(Maybe it's just a little unchecked checkbox at the bottom titled 'Active'.) |
|
The green checkmark is there now. Maybe the Travis/Github setup process was taking time. |
|
And #26 (a fresh, just-to-test-travis PR) triggered a build. I'm wondering if there was a problem with the "only when .travis.yml is present" option. |
|
No, sorry I wasn't clear. Travis CI was not present as an added Service. I added it and expected to see a checkmark, which I didn't find. I guess #26 triggered a build and so we are all good now. |
|
Ah, gotcha -- thanks! On Wed, Mar 25, 2015 at 10:05 AM, Amit Murthy notifications@github.com
|
|
Changes Unknown when pulling 78d32e5 on axsk:patch-1 into * on amitmurthy:master*. |
|
Hmmm... tested before committing and this passed on 0.3 and 0.4 locally. I believe the the failure on 0.4 on Travis is the same failure that keeps OpenStreetMap.jl failing (0.4, on Travis, not locally) failing downstream: Anyone seen similar elsewhere? |
|
The same issue on Travis has been present for HTTPClient.jl https://travis-ci.org/JuliaWeb/HTTPClient.jl/jobs/53431520 - I have been unable to figure it out. Happens on a I think you can go ahead and merge if it passes locally. Current master is also failing on Travis I guess. |
Fix deprecation of int(x) in Julia 0.4
Doing a Pkg.update() on the newest Julia nightly I receive a LOT of
slowing down the update process so much, that I actually canceled it after 10 minutes.
The provided ad-hoc patch solved this issue.
I did not check for other deprecated code, as I am not informed on these changes.
WARNING:
I do not know if this works with Julia 0.3.