Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BinaryProvider.jl #13

Merged
merged 20 commits into from
Dec 30, 2017
Merged

Conversation

davidanthoff
Copy link
Contributor

@davidanthoff davidanthoff commented Nov 8, 2017

Fixes #12.

@bicycle1885
Copy link
Member

Thank you very much! What is the reason for BinaryProvider.jl not to work?

@davidanthoff davidanthoff mentioned this pull request Nov 14, 2017
@davidanthoff davidanthoff changed the title WIP Use BinaryProvider.jl Use BinaryProvider.jl Dec 17, 2017
@davidanthoff
Copy link
Contributor Author

@bicycle1885 I think this is now ready to be merged! Would be great if you could then also tag a release, I hope to get Parquet.jl working on Windows and having a tagged version of Snappy.jl would be the next step for that.

For now the snappy binaries are hosted at https://github.com/davidanthoff/SnappyBuilder. We could move the repo to your account, if you want to have all the involved things under your account? It is a bit tricky to setup the travis authentication, so we could also just leave it under my account for now, given that everything works. I'd be happy to maintain it there.

@davidanthoff
Copy link
Contributor Author

@bicycle1885 Bump, any chance you could merge this and tag a new release? I have a whole set of other things that I'd like to move forward that all depend on this :) Thanks!

@bicycle1885
Copy link
Member

Thank you. I'll take a look today.

@bicycle1885 bicycle1885 merged commit 79f0ae8 into JuliaIO:master Dec 30, 2017
@bicycle1885
Copy link
Member

@davidanthoff Looks perfect! Thank you, again!. I've tagged Snappy.jl 0.2, so please wait for JuliaLang/METADATA.jl#12668.

@davidanthoff davidanthoff deleted the binaryprovider branch January 2, 2018 05:39
@davidanthoff
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants