Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor read_tarball to share tree construction logic #64

Open
StefanKarpinski opened this issue Jun 25, 2020 · 0 comments
Open

refactor read_tarball to share tree construction logic #64

StefanKarpinski opened this issue Jun 25, 2020 · 0 comments

Comments

@StefanKarpinski
Copy link
Member

Multiple usages of read_tarball now effectively want a tree representation of the tarball structure—tree hashing & symlink copying, in particular. Currently symlink copying doesn't build a tree and instead does a lot of splitting and joining on slashes, which is annoying and inefficient. The tree hashing code builds a tree for itself, but this same approach could probably be shared, simplifying both use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant