Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add public declarations using eval #175

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

lgoettgens
Copy link
Contributor

@lgoettgens lgoettgens commented Feb 8, 2024

Resolves the Tar.jl part of JuliaLang/julia#51335 as suggested in #173 (comment).

Alternative to and thus closes #174.

This might have semantical conflicts with #173, so please re-run CI after merge of #173.

cc @LilithHafner @stevengj

Copy link
Contributor

@LilithHafner LilithHafner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, provided someone familiar with the Tar API confirms that all documented behavior of create, extract, list, rewrite, tree_hash, and Header is part of the public API.

@stevengj
Copy link
Member

stevengj commented Feb 8, 2024

Those are the 6 things that are currently documented in the Tar.jl manual, so I think it's safe to say that they are public APIs.

@lgoettgens
Copy link
Contributor Author

I just updated this to contain the merge commit of #173 to make sure to not accidentally break something.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (166deb3) 97.53% compared to head (2a96754) 97.53%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files           4        4           
  Lines         810      810           
=======================================
  Hits          790      790           
  Misses         20       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LilithHafner
Copy link
Contributor

@stevengj, I think this is ready to merge.

@stevengj stevengj merged commit 9b5460b into JuliaIO:master Feb 15, 2024
17 checks passed
@lgoettgens lgoettgens deleted the lg/public-1 branch February 15, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants