Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safely error in generic Base.seekstart if in write mode. #159

Merged
merged 3 commits into from Nov 3, 2023
Merged

Safely error in generic Base.seekstart if in write mode. #159

merged 3 commits into from Nov 3, 2023

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Oct 17, 2023

This fixes one of the broken tests.

@nhz2
Copy link
Member Author

nhz2 commented Oct 31, 2023

CI failure seems to be due to codecov not working with the @checkmode macro. I could replace this macro with a normal function if that would help.

@ViralBShah
Copy link
Contributor

@nzh2 Invited you to this org. Please accept and also merge and tag.

@nhz2 nhz2 merged commit 7a1680c into JuliaIO:master Nov 3, 2023
17 of 18 checks passed
@nhz2 nhz2 deleted the seekstart-in-write-mode branch November 3, 2023 16:10
@nhz2 nhz2 mentioned this pull request Mar 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkitti mkitti Awaiting requested review from mkitti

@jakobnissen jakobnissen Awaiting requested review from jakobnissen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nhz2 @ViralBShah