Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add done mode #177

Merged
merged 1 commit into from Mar 6, 2024
Merged

Add done mode #177

merged 1 commit into from Mar 6, 2024

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Mar 6, 2024

If a stream is stopped when writing because the stop_on_end option was set, read should not suddenly start working.

To fix this I added a :done mode which is not readable. The existing :stop mode is still readable, but can only be reached through :read mode.

This doesn't fix the issues with eof described in #170

@nhz2 nhz2 marked this pull request as ready for review March 6, 2024 02:46
@nhz2 nhz2 requested a review from vtjnash March 6, 2024 03:21
Copy link
Contributor

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with the workings of the package. But a cursory glance looks good.

@nhz2 nhz2 merged commit f2916c9 into JuliaIO:master Mar 6, 2024
20 checks passed
@nhz2 nhz2 deleted the nz/done-state branch March 6, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants