Close underlying stream after process failure in close
#182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhz2
changed the title
close
mkitti
reviewed
Mar 26, 2024
| @@ -26,20 +26,20 @@ function TranscodingStreams.process( | |||
| codec :: DoubleFrameEncoder, | |||
| input :: TranscodingStreams.Memory, | |||
| output :: TranscodingStreams.Memory, | |||
| error :: TranscodingStreams.Error, | |||
| error_ref :: TranscodingStreams.Error, | |||
There was a problem hiding this comment.
I'm confused by this name change although I see it brings some clarity that this is actually a reference-like object. How is it related to the rest of the commit?
If you are going to keep this, please maintain the formatting alignment.
There was a problem hiding this comment.
I renamed it to avoid confusion with the Base.error function I had in the other process method. I'll fix up the formatting.
There was a problem hiding this comment.
I could change the docstring for process as well to be consistent but maybe there is a better name for this argument?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #160