Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Base.position #68

Merged
merged 2 commits into from
Mar 3, 2019
Merged

implement Base.position #68

merged 2 commits into from
Mar 3, 2019

Conversation

bicycle1885
Copy link
Member

Close #62.

@codecov-io
Copy link

codecov-io commented Mar 3, 2019

Codecov Report

Merging #68 into master will decrease coverage by 10.16%.
The diff coverage is 70%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #68       +/-   ##
===========================================
- Coverage   87.27%   77.11%   -10.17%     
===========================================
  Files          10       11        +1     
  Lines         393      638      +245     
===========================================
+ Hits          343      492      +149     
- Misses         50      146       +96
Impacted Files Coverage Δ
src/buffer.jl 95.34% <ø> (-4.66%) ⬇️
src/stream.jl 75.65% <70%> (-5.55%) ⬇️
src/testtools.jl 48.1% <0%> (-51.9%) ⬇️
src/codec.jl 66.66% <0%> (-33.34%) ⬇️
src/transcode.jl 90% <0%> (-10%) ⬇️
src/noop.jl 90% <0%> (-2.86%) ⬇️
src/error.jl 14.28% <0%> (-2.39%) ⬇️
src/io.jl 100% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dfb063...f6cc403. Read the comment docs.

@bicycle1885 bicycle1885 merged commit 144b3cf into master Mar 3, 2019
@bicycle1885 bicycle1885 deleted the position branch March 3, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants