Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for variable-length strings #116

Merged
merged 2 commits into from
Jun 8, 2023
Merged

add support for variable-length strings #116

merged 2 commits into from
Jun 8, 2023

Conversation

ilia-kats
Copy link
Contributor

This uses the vlen-utf8 filter, which is one of the standard filters included with Python-Zarr.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4819715507

  • 26 of 30 (86.67%) changed or added relevant lines in 3 files are covered.
  • 14 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-1.4%) to 85.012%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Filters.jl 22 23 95.65%
src/ZArray.jl 2 3 66.67%
src/metadata.jl 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
src/ZArray.jl 2 94.29%
src/MaxLengthStrings.jl 5 33.33%
src/metadata.jl 7 78.49%
Totals Coverage Status
Change from base Build 4698045635: -1.4%
Covered Lines: 726
Relevant Lines: 854

💛 - Coveralls

ilia-kats added a commit to scverse/Muon.jl that referenced this pull request Apr 28, 2023
Only non-backed reading works currently. This requires
JuliaIO/Zarr.jl#116 and
JuliaIO/Zarr.jl#117
Copy link
Collaborator

@meggart meggart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for preparing this PR. It would be really nice to have VLenUTF8 support in here. I think technically the PR would be breaking because dumping a string vector into a zarr array would result into a different representation on disk as before. So I would make sure bunp the minor version in this PR to not forget.

x::Array{T,N}
senval::T
end
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knwo this was a quite ad-hoc definition of SenMissArray, probably better to keep the sentinel value in a struct field instead of a type parameter. Now that the idea was taken up also here: https://github.com/JuliaData/SentinelArrays.jl it might be an option to just use that implementation. This should not stop this PR from being merged though.

src/ZArray.jl Show resolved Hide resolved
src/metadata.jl Show resolved Hide resolved
@meggart meggart mentioned this pull request Jun 6, 2023
@meggart meggart merged commit 6be3259 into JuliaIO:master Jun 8, 2023
@coveralls
Copy link

coveralls commented May 20, 2024

Pull Request Test Coverage Report for Build 4819746815

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 27 of 32 (84.38%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 85.814%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Filters.jl 22 23 95.65%
src/ZArray.jl 3 5 60.0%
src/metadata.jl 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
src/MaxLengthStrings.jl 5 33.33%
Totals Coverage Status
Change from base Build 4698045635: -0.6%
Covered Lines: 738
Relevant Lines: 860

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants