-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for variable-length strings #116
Conversation
Pull Request Test Coverage Report for Build 4819715507
💛 - Coveralls |
Only non-backed reading works currently. This requires JuliaIO/Zarr.jl#116 and JuliaIO/Zarr.jl#117
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for preparing this PR. It would be really nice to have VLenUTF8 support in here. I think technically the PR would be breaking because dumping a string vector into a zarr array would result into a different representation on disk as before. So I would make sure bunp the minor version in this PR to not forget.
x::Array{T,N} | ||
senval::T | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I knwo this was a quite ad-hoc definition of SenMissArray, probably better to keep the sentinel value in a struct field instead of a type parameter. Now that the idea was taken up also here: https://github.com/JuliaData/SentinelArrays.jl it might be an option to just use that implementation. This should not stop this PR from being merged though.
Pull Request Test Coverage Report for Build 4819746815Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This uses the
vlen-utf8
filter, which is one of the standard filters included with Python-Zarr.