Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project.toml #101

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Update Project.toml #101

merged 2 commits into from
Nov 14, 2022

Conversation

alex-s-gardner
Copy link
Contributor

Added and tested HTTP 1.5 as a dependency. This solves Issue #100

@coveralls
Copy link

coveralls commented Nov 11, 2022

Pull Request Test Coverage Report for Build 3449113481

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.808%

Totals Coverage Status
Change from base Build 2991481048: 0.0%
Covered Lines: 653
Relevant Lines: 761

💛 - Coveralls

@felixcremer
Copy link
Contributor

I think that when the aim is to restrict HTTP to versions higher than 1.5 you need to delete the single 1 in the compat entry.
Otherwise this entry allows all versions that are between 1.0.0 and lower than 2.0.0.

modified DiskArrays dependency to ensure inclusion of batch getindex
modified HTTP dependency to prevent hanging
@meggart
Copy link
Collaborator

meggart commented Nov 14, 2022

Thank you! I think it would have been possible to omit the caret specifier because it is the default anyway but it might be better to be explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants