problem with resolve_dependency!(dag::ExprDAG, node::ExprNode{<:AbstractMacroNodeType, options)

[jkozdon]

I've been trying to revive some PETSc wrappers I started a long time ago, and upon updating Clang.jl to the latest release I ran into a problem caused by e6022d2.

When this commit is applied, the RemoveCircularReference pass just loops forever.

If I revert these changes, even with the latest master branch, the code will at least complete for a simple test case.

I've tried to strip things down pretty minimally in this gist for what I am running.

[Gnimuc]

cc @melonedo

[melonedo]

This is because PETSc_jll/include/pestclog.h defines macros that "hide" the implementation, which looks like circular reference.

#define foo(a,b,c) log(a,b,c); foo(a,b,c)